Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propagate handshake error #6530

Conversation

hansieodendaal
Copy link
Contributor

Description

Propagate handshake error to next process. This was omitted in #6528.

Motivation and Context

See above.

How Has This Been Tested?

System-level testing.

What process can a PR reviewer use to test or verify this change?

Code review.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

github-actions bot commented Sep 5, 2024

Test Results (CI)

    3 files    129 suites   41m 20s ⏱️
1 308 tests 1 307 ✅ 0 💤 1 ❌
3 910 runs  3 909 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit da77b58.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Test Results (Integration tests)

36 tests   36 ✅  15m 42s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit da77b58.

@SWvheerden SWvheerden merged commit e29c909 into tari-project:development Sep 5, 2024
15 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_propagate_handshake_error branch September 5, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants