feat: add resilience to initial wallet connect #6527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 129 suites 39m 29s ⏱️ Results for commit 4ce5566. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files 11 suites 17m 9s ⏱️ For more details on these failures, see this check. Results for commit 4ce5566. ♻️ This comment has been updated with latest results. |
hansieodendaal
force-pushed
the
ho_wallet_connect_at_startup
branch
4 times, most recently
from
694aca7 to
3dc8b37
Compare
hansieodendaal
force-pushed
the
ho_wallet_connect_at_startup
branch
4 times, most recently
from
3b4fd29 to
89e2e82
Compare
Added resiliance to initial wallet connect, where the wallet will try all base nodes or all seeds it knows of and not only one it chose at random.
hansieodendaal
force-pushed
the
ho_wallet_connect_at_startup
branch
from
89e2e82 to
4ce5566
Compare
SWvheerden
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added resilience to the initial wallet connection in cases where a custom base node has not been set, where the wallet will try all base nodes or all seeds it knows of and not only one it chose at random.
Motivation and Context
Wallets would try indefinitely to establish an initial connection to an offline peer.
How Has This Been Tested?
Start a wallet with multiple custom seed nodes where only one is online. Shut down the wallet after the established connection, delete its peer db, and redo. Do this multiple times. Confirm that the wallet establishes a connection every time.
What process can a PR reviewer use to test or verify this change?
Review code changes
Breaking Changes