Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: paper wallet cli #6522

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Add paper wallet to console wallet
Add scrape wallet to wallet FFI

Motivation and Context

This will allow you to import a paper wallet to your own wallet

How Has This Been Tested?

Manual

@SWvheerden SWvheerden requested a review from a team as a code owner September 3, 2024 14:38
Copy link

github-actions bot commented Sep 3, 2024

Test Results (CI)

    3 files    129 suites   38m 2s ⏱️
1 308 tests 1 308 ✅ 0 💤 0 ❌
3 910 runs  3 910 ✅ 0 💤 0 ❌

Results for commit 8fe70f3.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Test Results (Integration tests)

36 tests   36 ✅  14m 34s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit 8fe70f3.

Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Maybe just use a TempFile instead so that it gets deleted on drop

@SWvheerden SWvheerden merged commit 31a953c into tari-project:development Sep 4, 2024
17 checks passed
@SWvheerden SWvheerden deleted the sw_paper_wallet branch September 10, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants