fix(comms): always send disconnect notification to conn manager #6511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
previously approved these changes
Aug 30, 2024
ghpbot-tari-project
added
the
P-acks_required
sdbondi
force-pushed
the
comms-fix-disconnect-state
branch
from
51f3057 to
b07794e
Compare
ghpbot-tari-project
added
the
P-reviews_required
SWvheerden
approved these changes
Aug 30, 2024
Test Results (CI) 3 files 129 suites 38m 7s ⏱️ Results for commit b07794e. |
ghpbot-tari-project
removed
the
P-reviews_required
Test Results (Integration tests) 2 files + 2 11 suites +11 35m 31s ⏱️ + 35m 31s For more details on these failures, see this check. Results for commit b07794e. ± Comparison against base commit 169572a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(comms): always send disconnect notification to conn manager
fix(comms): take the connection state into account when determining connectedness for tie-breaking
Motivation and Context
Previously, if Yamux detected that we were disconnected, the connectivity manager
Disconnectednotification would not be sent. A race condition with disconnects on a connection and the remote disconnecting happen at almost the same time. If the latter happens first, then the notification of the disconnect would not be sent to the connection manager. When a new connection is attempted, the connection manager would think that a previous connection exists.Ref #6512
Ref #6513
How Has This Been Tested?
Not explicitly tested, difficult to reproduce.
What process can a PR reviewer use to test or verify this change?
Breaking Changes