feat(p2pool-randomx-support): added pow algo to GetNewBlockRequest in p2pool proto #6509
Conversation
Test Results (CI) 3 files 129 suites 36m 50s ⏱️ Results for commit d979afc. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)36 tests 36 ✅ 15m 1s ⏱️ Results for commit d979afc. ♻️ This comment has been updated with latest results. |
…into feature/p2pool-randomx-support
| @@ -455,8 +457,10 @@ async fn get_new_block_base_node( | |||
| async fn get_new_block_p2pool_node( | |||
| sha_p2pool_client: &mut ShaP2PoolGrpcClient, | |||
| ) -> Result<GetNewBlockResponse, MinerError> { | |||
| let mut pow_algo = PowAlgo::default(); | |||
There was a problem hiding this comment.
why not just declare immediately with he correct value
There was a problem hiding this comment.
because it is simpler to do this as I did not see any method or something that would use PowAlgos type to have the right pow algo.
There was a problem hiding this comment.
Feels like there is a way, but this is fine for now
There was a problem hiding this comment.
Actually I did not find any better yet, since there is no method for that to initialize a PowAlgo from PowAlgos enum (it is the enum which contains i32 value for PowAlgo), so not sure.
| @@ -455,8 +457,10 @@ async fn get_new_block_base_node( | |||
| async fn get_new_block_p2pool_node( | |||
| sha_p2pool_client: &mut ShaP2PoolGrpcClient, | |||
| ) -> Result<GetNewBlockResponse, MinerError> { | |||
| let mut pow_algo = PowAlgo::default(); | |||
There was a problem hiding this comment.
Feels like there is a way, but this is fine for now
Description
Added PoW algo to p2pool client request, so clients can get a SHA-3 or Random-X block to mine on.
Breaking Changes