feat: add more verbose comms errors #6507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more verbose comms errors
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 129 suites 39m 36s ⏱️ Results for commit 9c3e393. ♻️ This comment has been updated with latest results. |
SWvheerden
reviewed
Aug 29, 2024
SWvheerden
approved these changes
Aug 29, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added more verbose comms errors.
Motivation and Context
Trying to hunt down an edge case where a wallet (as RPC client) continuously connects and then disconnects to a base node (as RPC server) due to no more RPC sessions available, while it seems ample RPC sessions are available when looking at the base node console.
How Has This Been Tested?
Pass all unit tests
What process can a PR reviewer use to test or verify this change?
Code review
Breaking Changes