Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the expected return errors in ledger demo #6506

Merged

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Aug 28, 2024

Description

Just changes the expected error returns to match reality.

Motivation and Context

So the whole demo can pass

How Has This Been Tested?

Run the demo

@brianp brianp changed the title Correct the expected return errors fix: correct the expected return errors in ledger demo Aug 28, 2024
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 28, 2024
Copy link

Test Results (CI)

    3 files    129 suites   39m 4s ⏱️
1 306 tests 1 306 ✅ 0 💤 0 ❌
3 904 runs  3 904 ✅ 0 💤 0 ❌

Results for commit 1ab1e28.

Copy link

Test Results (Integration tests)

37 tests  +37   37 ✅ +37   16m 24s ⏱️ + 16m 24s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 1ab1e28. ± Comparison against base commit 7cb88fa.

@SWvheerden SWvheerden changed the title fix: correct the expected return errors in ledger demo fix: correct the expected return errors in ledger demo Aug 29, 2024
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Aug 29, 2024
@SWvheerden SWvheerden merged commit 8d5da30 into tari-project:development Aug 29, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants