Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit open-ended vectors for tari script #6501

Conversation

hansieodendaal
Copy link
Contributor

Description

Limited open-ended vectors to guard against malicious network messages in:

  • tari-script

Motivation and Context

This is a defense-in-depth exercise.

How Has This Been Tested?

Existing unit tests pass.

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner August 22, 2024 09:43
Copy link

github-actions bot commented Aug 22, 2024

Test Results (CI)

    3 files    129 suites   34m 39s ⏱️
1 306 tests 1 306 ✅ 0 💤 0 ❌
3 904 runs  3 904 ✅ 0 💤 0 ❌

Results for commit 7a91af0.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   25m 27s ⏱️ + 25m 27s
37 tests +37  35 ✅ +35  0 💤 ±0  2 ❌ +2 
40 runs  +40  36 ✅ +36  0 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 7a91af0. ± Comparison against base commit e734269.

♻️ This comment has been updated with latest results.

@hansieodendaal hansieodendaal force-pushed the ho_limit_open_ended_vectors_tari_script branch from 3b016f1 to 3fa2150 Compare August 26, 2024 06:44
SWvheerden
SWvheerden previously approved these changes Aug 26, 2024
infrastructure/max_size/Cargo.toml Outdated Show resolved Hide resolved
@SWvheerden SWvheerden merged commit f91cffa into tari-project:development Aug 26, 2024
15 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_limit_open_ended_vectors_tari_script branch August 26, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants