Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit open-ended vectors for covenants #6497

Conversation

hansieodendaal
Copy link
Contributor

Description

Limited open-ended vectors to guard against malicious network messages in:

  • covenants

Motivation and Context

This is a defense-in-depth exercise.

How Has This Been Tested?

Existing unit tests pass.

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner August 21, 2024 15:57
@hansieodendaal hansieodendaal requested a review from sdbondi August 21, 2024 15:58
Copy link

github-actions bot commented Aug 21, 2024

Test Results (CI)

    3 files    129 suites   35m 28s ⏱️
1 306 tests 1 306 ✅ 0 💤 0 ❌
3 904 runs  3 904 ✅ 0 💤 0 ❌

Results for commit cb2b128.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Test Results (Integration tests)

37 tests   37 ✅  16m 5s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit cb2b128.

♻️ This comment has been updated with latest results.

@hansieodendaal hansieodendaal force-pushed the ho_limit_open_ended_vectors_covenant branch from 804f1b8 to dd99286 Compare August 26, 2024 11:40
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Aug 26, 2024
@SWvheerden SWvheerden merged commit 7a1150d into tari-project:development Aug 26, 2024
16 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_limit_open_ended_vectors_covenant branch August 27, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants