Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default ledger wallet #6479

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes the ledger default options

Motivation and Context

Ledger should be enabled by default for the console wallet.

How Has This Been Tested?

Manual

Copy link

Test Results (CI)

    3 files    126 suites   43m 27s ⏱️
1 307 tests 1 307 ✅ 0 💤 0 ❌
3 907 runs  3 907 ✅ 0 💤 0 ❌

Results for commit 894d020.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 19, 2024
Copy link

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   43m 30s ⏱️ + 43m 30s
37 tests +37  35 ✅ +35  0 💤 ±0  2 ❌ +2 
40 runs  +40  36 ✅ +36  0 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 894d020. ± Comparison against base commit a67b79d.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

We must just be sure that the cucumber tests are happy. This one failed, but I restarted the tests:

All 3 runs failed: Scenario: As a client I want to send a one-sided transaction: tests/features/WalletFFI.feature:175:5

@SWvheerden
Copy link
Collaborator Author

thats a super flaky test

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Aug 20, 2024
@SWvheerden SWvheerden merged commit b50838f into tari-project:development Aug 20, 2024
15 of 17 checks passed
@SWvheerden SWvheerden deleted the sw_fix_ledger_default branch August 21, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants