fix: contact service tari address support #6478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (Integration tests) 2 files 11 suites 27m 57s ⏱️ For more details on these failures, see this check. Results for commit 91cea55. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 126 suites 39m 39s ⏱️ Results for commit 91cea55. ♻️ This comment has been updated with latest results. |
SWvheerden
force-pushed
the
sw_fix_contacts
branch
from
720ac93 to
91cea55
Compare
hansieodendaal
approved these changes
Aug 20, 2024
Comment on lines
+184
to
+185
| one.public_spend_key().clone(), | ||
| one.network(), |
There was a problem hiding this comment.
The logic would be more consistent this way:
Suggested change
| one.public_spend_key().clone(), | |
| one.network(), | |
| two.public_spend_key().clone(), | |
| two.network(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contact service still assumes that the node_id and tari address are the same. This changes contact service to check the tari address.
Motivation and Context
This allows a user to update the address of a contact without having to delete the contact. It will look at the address given and update the address accordingly.
How Has This Been Tested?
Manual