feat!: add source address to encrypted data #6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 126 suites 50m 54s ⏱️ Results for commit 48c0df7. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
SWvheerden
force-pushed
the
sw_add_source_address
branch
from
9f95245 to
58cd97c
Compare
hansieodendaal
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
utACK
(Please add an issue to make adding the sender address in encrypted data optional for (a) change, (b) interactive transactions and (c) one-sided transactions. For one-sided transactions the sender should have the ability to decide when creating the transaction. See #6475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the source address to encrypted data
Motivation and Context
This allows a one-sided payment to send over its address to the receiving wallet
It also allows a wallet recovering funds to see where the funds came from.
How Has This Been Tested?
unit test and manual