Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new genesis blocks #6471

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

hansieodendaal
Copy link
Contributor

Description

Added new genesis blocks for esmeralda and mainnet (test only!)

Motivation and Context

We need new genesis blocks to test the pre-mine spend.

How Has This Been Tested?

Unit tests (esmeralda_genesis_sanity_check and mainnet_genesis_sanity_check) pass

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Added new genesis blocks for esmeralda and mainnet (test only!)
@hansieodendaal hansieodendaal requested a review from a team as a code owner August 16, 2024 09:41
Copy link

Test Results (CI)

    3 files    126 suites   41m 33s ⏱️
1 306 tests 1 306 ✅ 0 💤 0 ❌
3 904 runs  3 904 ✅ 0 💤 0 ❌

Results for commit 2bbdbc2.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 16, 2024
Copy link

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   42m 22s ⏱️ + 42m 22s
37 tests +37  36 ✅ +36  0 💤 ±0  1 ❌ +1 
39 runs  +39  36 ✅ +36  0 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 2bbdbc2. ± Comparison against base commit 777869d.

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit

@@ -683,7 +683,7 @@ impl ConsensusConstants {
max_randomx_seed_height: 3000,
max_extra_field_size: 200,
proof_of_work: algos,
pre_mine_value: MicroMinotari::from(0),
pre_mine_value: ((21_000_000_000 - 14_700_000_000) * 1_000_000).into(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a constant?

@SWvheerden SWvheerden merged commit 3828796 into tari-project:development Aug 16, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants