Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: limit open ended vectors in chat #6467

Merged
merged 2 commits into from
Aug 15, 2024
Merged

feat: limit open ended vectors in chat #6467

merged 2 commits into from
Aug 15, 2024

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Aug 14, 2024 •
edited
Loading

Description

  • Limited open-ended vectors in chat to guard against malicious network messages.
  • Fixed instability issues with chat FFI cucumber tests.

Motivation and Context

This is a defense-in-depth exercise.

How Has This Been Tested?

  • Existing unit tests pass.
  • Added new unit tests to test all limits

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner August 14, 2024 10:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

Test Results (CI)

    3 files    126 suites   35m 56s ⏱️
1 305 tests 1 305 ✅ 0 💤 0 ❌
3 907 runs  3 907 ✅ 0 💤 0 ❌

Results for commit 5ec666a.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

Test Results (Integration tests)

 2 files  11 suites   43m 5s ⏱️
37 tests 35 ✅ 0 💤 2 ❌
41 runs  35 ✅ 0 💤 6 ❌

For more details on these failures, see this check.

Results for commit 5ec666a.

♻️ This comment has been updated with latest results.

SWvheerden
SWvheerden reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

base_layer/chat_ffi/src/contacts.rs Outdated Show resolved Hide resolved
base_layer/chat_ffi/src/contacts.rs Outdated Show resolved Hide resolved
@hansieodendaal hansieodendaal force-pushed the ho_limit_open_ended_vectors branch from 57ccbb3 to 5e21217 Compare August 15, 2024 12:32
@hansieodendaal
Limit open ended vectors
ccafc69 
Limited some more open ended vectors to guard against malicious nework messages.
@hansieodendaal
fix chat ffi integration tests
5ec666a
@hansieodendaal hansieodendaal force-pushed the ho_limit_open_ended_vectors branch from 5e21217 to 5ec666a Compare August 15, 2024 12:48
@SWvheerden SWvheerden merged commit 777869d into tari-project:development Aug 15, 2024
16 of 18 checks passed
@hansieodendaal hansieodendaal deleted the ho_limit_open_ended_vectors branch August 16, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansieodendaal @SWvheerden @ghpbot-tari-project