Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sender offset key #6465

Conversation

hansieodendaal
Copy link
Contributor

Description

Updated sender offset key in fail-safe pre-mine spend

Motivation and Context

The way sender offset keys are handled changed after this function was created.

How Has This Been Tested?

None - need to do system-level fail-safe pre-mine spend tests.

What process can a PR reviewer use to test or verify this change?

Perform system-level fail-safe pre-mine spend tests after creating a new pre-mine genesis block.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner August 12, 2024 14:45
Copy link

Test Results (CI)

    3 files    126 suites   35m 27s ⏱️
1 303 tests 1 303 ✅ 0 💤 0 ❌
3 901 runs  3 901 ✅ 0 💤 0 ❌

Results for commit 2db9730.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 12, 2024
Copy link

Test Results (Integration tests)

 2 files   1 errors  9 suites   11m 15s ⏱️
19 tests 18 ✅ 0 💤 1 ❌
20 runs  19 ✅ 0 💤 1 ❌

For more details on these parsing errors and failures, see this check.

Results for commit 2db9730.

@SWvheerden SWvheerden merged commit 4601530 into tari-project:development Aug 13, 2024
15 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_fail_safe_spend_sender_offset_key branch August 13, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants