feat!: ledger metadata signature with receiver adress confirmation #6462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 126 suites 41m 30s ⏱️ Results for commit 4e6a0d0. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 1 errors 9 suites +9 20m 23s ⏱️ + 20m 23s For more details on these parsing errors and failures, see this check. Results for commit 4e6a0d0. ± Comparison against base commit 310a470. ♻️ This comment has been updated with latest results. |
… hash those hashes
hansieodendaal
force-pushed
the
bp-feat-ledger-script-generation
branch
from
18b29d2 to
0baae9c
Compare
hansieodendaal
force-pushed
the
bp-feat-ledger-script-generation
branch
from
0baae9c to
5ce49b1
Compare
hansieodendaal
changed the title
hansieodendaal
changed the title
SWvheerden
requested changes
Aug 12, 2024
applications/minotari_ledger_wallet/comms/src/accessor_methods.rs
Outdated
Show resolved
Hide resolved
applications/minotari_ledger_wallet/wallet/src/handlers/get_one_sided_metadata_signature.rs
Outdated
Show resolved
Hide resolved
SWvheerden
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send the user spend public key to the ledger for script generation and user validation via the ledger device.
Motivation and Context
Initially we though we would need to send all the parts to the ledger, instead we will change the format by hashing the script, and hashing all other fields, then hashing those hashes.
This allows us to hash the other fields, and send just the hash to the ledger instead of serializing all the independent parts (covenants, encrypted data, etc.) As they have variable lengths and it gets messy quick.
Then we can send just the receiver public spend key to the ledger, and use it to generate the entire TariScript for the message, after the user has verified the address on the ledger screen.
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes