feat: don't permit trying to send interactive transfers from hardware devices #6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
bp-feat-block-ledger-interactive-sends
branch
from
2f61c94 to
8c02cf7
Compare
Test Results (CI) 3 files 123 suites 38m 16s ⏱️ Results for commit 8c02cf7. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 1 errors 9 suites 11m 42s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 8c02cf7. |
SWvheerden
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Block the sending of interactive transfers from the UX, and remove instructions on how to do so.
Motivation and Context
We don't support interactive transfers from ledger, and the transaction will fail if you try.
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Create a ledger wallet, and note the instructions are gone and pressing "S" does nothing.
Breaking Changes