feat: remove pre-mine create commands from the console wallet #6451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 123 suites 39m 17s ⏱️ Results for commit e277c53. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 1 errors 9 suites 13m 29s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit e277c53. ♻️ This comment has been updated with latest results. |
hansieodendaal
force-pushed
the
ho_remove_pre_mine_create
branch
2 times, most recently
from
fb7cc69 to
64eecec
Compare
Added pre-mine information to the esmeralda genesis block
Removed pre-mine create commands and associated code from the console wallet.
hansieodendaal
force-pushed
the
ho_remove_pre_mine_create
branch
from
927c071 to
e277c53
Compare
SWvheerden
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed pre-mine create commands and associated code from the console wallet.
Motivation and Context
This is a simple task and a console wallet is not needed to perform it.
How Has This Been Tested?
Code compiled successfully.
Unit tests pass.
What process can a PR reviewer use to test or verify this change?
Code review.
Breaking Changes