feat: add private view key function #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Aug 5, 2024
Test Results (CI) 3 files 123 suites 42m 21s ⏱️ Results for commit e7cd579. |
ghpbot-tari-project
added
the
P-acks_required
4 tasks
Test Results (Integration tests) 2 files 1 errors 9 suites 11m 56s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit e7cd579. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a private view key function to transaction key manager service
Motivation and Context
We must be able to export the private view of the wallet. And to do this we should not be required to expose the secret trait giving access to all private keys in order to get this exported.