Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Ledger readme #6443

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

  • Updated the Ledger README.md file.
  • Updated the Ledger application error message to prompt a Ledger firmware upgrade.

Motivation and Context

The Ledger instructions were clear enough

How Has This Been Tested?

Followed the steps

What process can a PR reviewer use to test or verify this change?

Follow the steps to review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

github-actions bot commented Aug 3, 2024

Test Results (CI)

    3 files    123 suites   42m 1s ⏱️
1 300 tests 1 299 ✅ 0 💤 1 ❌
3 892 runs  3 891 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 31ff547.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 3, 2024
Copy link

github-actions bot commented Aug 3, 2024

Test Results (Integration tests)

19 tests  +19   19 ✅ +19   10m 58s ⏱️ + 10m 58s
 9 suites + 9    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 
 1 errors

For more details on these parsing errors, see this check.

Results for commit 31ff547. ± Comparison against base commit af1f451.

♻️ This comment has been updated with latest results.

- Updated the Ledger README.md file.
- Updated the Ledger application error message to prompt a Ledger firmware upgrade.
@hansieodendaal hansieodendaal force-pushed the ho_update_ledger_readme branch from cfbb289 to fa690f3 Compare August 3, 2024 05:35
@SWvheerden SWvheerden merged commit 6f7318b into tari-project:development Aug 5, 2024
14 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_update_ledger_readme branch August 5, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants