-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pre-mine spend #6442
feat: add pre-mine spend #6442
Conversation
Added pre-mine spend with improved logging for fault finding
Test Results (Integration tests) 2 files + 2 1 errors 9 suites +9 11m 24s ⏱️ + 11m 24s For more details on these parsing errors and failures, see this check. Results for commit c1eb2ed. ± Comparison against base commit af1f451. ♻️ This comment has been updated with latest results. |
Test Results (CI) 3 files 123 suites 42m 7s ⏱️ For more details on these failures, see this check. Results for commit c1eb2ed. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key manager should not impose limitations on which keys it must use where.
That must be decided by the calling logic.
The key manager should look at the key type and decide what to do.
applications/minotari_ledger_wallet/wallet/src/handlers/get_script_offset.rs
Outdated
Show resolved
Hide resolved
applications/minotari_ledger_wallet/wallet/src/handlers/get_script_offset.rs
Outdated
Show resolved
Hide resolved
112dee7
to
13fe8db
Compare
I haven't reviewed the changes yet but it is functional: All scenarios produce spendable outputs. |
Description
Added pre-mine spend with improved logging for fault finding
Motivation and Context
Pre-mine spending did not work.
How Has This Been Tested?
A new esmeralda genesis block that includes pre-mine with a 2-of-3 scheme and a backup spending wallet was created, utilizing 4x ledger console wallets. Those wallets were then used to spend the 1st pre-mine UTXO. The UTXO was successfully mined and imported into the target wallet.
Leader's ledger console wallet console:
Party member's ledger console wallet console:
What process can a PR reviewer use to test or verify this change?
Code review
System-level testing
Breaking Changes