Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lagging code #6441

Merged

Conversation

stringhandler
Copy link
Collaborator

Fixes a bug where the node would not reorg to a chain with a lower height, even if it had a higher difficulty

@stringhandler stringhandler requested a review from a team as a code owner August 1, 2024 11:20
Copy link

github-actions bot commented Aug 1, 2024

Test Results (CI)

    3 files    123 suites   41m 37s ⏱️
1 299 tests 1 298 ✅ 0 💤 1 ❌
3 888 runs  3 887 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 579bf44.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Test Results (Integration tests)

19 tests   19 ✅  11m 15s ⏱️
 9 suites   0 💤
 2 files     0 ❌
 1 errors

For more details on these parsing errors, see this check.

Results for commit 579bf44.

♻️ This comment has been updated with latest results.

SWvheerden
SWvheerden previously approved these changes Aug 1, 2024
@SWvheerden SWvheerden changed the title fix: fix lagging code fix: lagging code Aug 1, 2024
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@SWvheerden SWvheerden merged commit af1f451 into tari-project:development Aug 2, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants