Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scanned height #6440

Merged

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Jul 31, 2024

Description

adds a callback to the FFI to get access to the height the wallet scanned blocks to
Adds a UI display to console wallet to view the displayed height

Motivation and Context

Just showing the tip height of the block chain does not have that high a meaning, its the scanned height that's important an we should show this.

How Has This Been Tested?

Manual + unit tests

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

Test Results (CI)

    3 files    114 suites   40m 57s ⏱️
1 296 tests 1 295 ✅ 0 💤 1 ❌
3 697 runs  3 696 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit f56d9de.

♻️ This comment has been updated with latest results.

Copy link

Test Results (Integration tests)

 2 files   1 errors  9 suites   11m 9s ⏱️
19 tests 18 ✅ 0 💤 1 ❌
21 runs  18 ✅ 0 💤 3 ❌

For more details on these parsing errors and failures, see this check.

Results for commit f56d9de.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Aug 1, 2024
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often is the known tip, and scanned height different? I'd usually expect the scanned height to catch up fairly fast. What's the use case / reason we're building for here?

@SWvheerden
Copy link
Collaborator Author

Fairly ofter actually.
If you watch your wallet when mining, it take a few seconds to scan the new mined height, although the base_node already shows height mined.

You see the behavior in when the height shown is at tip, but you don't see your coinbase yet.

Also when you stop and start the wallet, which is a big thing for mobile. It becomes a big issue.

@SWvheerden SWvheerden merged commit ad14053 into tari-project:development Aug 1, 2024
13 of 17 checks passed
@SWvheerden SWvheerden deleted the sw_add_scanned_height branch August 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants