Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync cli #6435

Merged
merged 3 commits into from
Jul 31, 2024
Merged

feat: sync cli #6435

merged 3 commits into from
Jul 31, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Adds a cli command for the wallet to sync to tip, and validate all outputs

Motivation and Context

This will allow a wallet to be offline, and only come on to scan to the tip, validate the outputs it got and return the balance the wallet has on the tip.

How Has This Been Tested?

Manual

1. Sync(SyncArgs { sync_to_height: 0 })

Waiting for connectivity... ✅
Connecting to base node...
Connected to base node
Progress: 4499/4499
Completed! Height: 4499, UTXOs recovered: 2, Value recovered: 200.000000 T, Time taken: 5
Starting validation process
Validation succeeded
balance as of scanning height
Available balance: 200.000000 T
Time locked: 0 µT
Pending incoming balance: 0 µT
Pending outgoing balance: 0 µT

Copy link

github-actions bot commented Jul 30, 2024

Test Results (CI)

    3 files    123 suites   47m 12s ⏱️
1 298 tests 1 298 ✅ 0 💤 0 ❌
3 886 runs  3 886 ✅ 0 💤 0 ❌

Results for commit ce41b0b.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 30, 2024
Copy link

github-actions bot commented Jul 30, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   24m 7s ⏱️ + 24m 7s
35 tests +35  34 ✅ +34  0 💤 ±0  1 ❌ +1 
36 runs  +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit ce41b0b. ± Comparison against base commit 5a33bc8.

♻️ This comment has been updated with latest results.

@brianp
Copy link
Contributor

brianp commented Jul 31, 2024

Trying to read between the lines here.

It's to get the wallet up to sync, without making the wallet available?

@SWvheerden
Copy link
Collaborator Author

yeah

Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@SWvheerden SWvheerden merged commit f7ffe1d into tari-project:development Jul 31, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_sync_cli branch August 5, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants