Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backup spend for pre-mine #6431

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Adds backup pre-mine spend functionality.

@SWvheerden SWvheerden requested a review from a team as a code owner July 26, 2024 09:54
@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   33m 21s ⏱️ + 33m 21s
35 tests +35  33 ✅ +33  0 💤 ±0  2 ❌ +2 
38 runs  +38  35 ✅ +35  0 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit ea35218. ± Comparison against base commit 3377e9c.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Test Results (CI)

    3 files    123 suites   37m 51s ⏱️
1 298 tests 1 298 ✅ 0 💤 0 ❌
3 886 runs  3 886 ✅ 0 💤 0 ❌

Results for commit ea35218.

♻️ This comment has been updated with latest results.

hansieodendaal
hansieodendaal previously approved these changes Jul 29, 2024
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

I am happy if all the tests and clippy pass.

@@ -1491,6 +1511,243 @@ where
))
}

#[allow(clippy::too_many_lines)]
pub async fn spend_backup_pre_mine_utxo(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in another PR (to be prioritized) we can DRY up the code in these functions, as many parts of this function look the same as the one that spends via the m-of-n path.

@SWvheerden SWvheerden merged commit 1224b6a into tari-project:development Jul 29, 2024
13 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_spend_backup branch July 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants