feat(wallet): add view key commands #6426
Conversation
Test Results (CI) 3 files 123 suites 38m 48s ⏱️ Results for commit 6cda68e. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)19 tests 19 ✅ 10m 54s ⏱️ For more details on these parsing errors, see this check. Results for commit 6cda68e. ♻️ This comment has been updated with latest results. |
# Conflicts: # applications/minotari_console_wallet/src/automation/commands.rs # applications/minotari_console_wallet/src/cli.rs # applications/minotari_console_wallet/src/init/mod.rs
| @@ -75,7 +75,7 @@ use tari_core::{ | |||
| blocks::pre_mine::{create_pre_mine_genesis_block_file, get_pre_mine_items, PreMineItem}, | |||
| covenants::Covenant, | |||
| transactions::{ | |||
| key_manager::TransactionKeyManagerInterface, | |||
| key_manager::{SecretTransactionKeyManagerInterface, TransactionKeyManagerInterface}, | |||
There was a problem hiding this comment.
We should not use this trait:
#6447
| return Some(WalletType::default()); | ||
| } | ||
|
|
||
| match boot_mode { | ||
| WalletBoot::ViewAndSpendKey => { | ||
| let view_key = if let Some(vk) = view_private_key { | ||
| match PrivateKey::from_base58(&vk) { |
There was a problem hiding this comment.
in the command window you use hex, here its base58?
| }; | ||
| let spend_key = if | ||
| let Some(sk) = spend_key { | ||
| let spend_key = match PublicKey::from_base58(&sk) { |
There was a problem hiding this comment.
same as other command hex vs base58
| .private_spend_key | ||
| .clone() | ||
| .ok_or(KeyManagerServiceError::ImportedPrivateKeyInaccessible); | ||
| return Ok(PrivateKey::default()); |
There was a problem hiding this comment.
I think this will have a conflict anyway, make sure to choose the current code in origin. This error here is fixed.
# Conflicts: # base_layer/core/src/transactions/key_manager/inner.rs
ghpbot-tari-project
removed
the
P-reviews_required
stringhandler
merged commit 77e5ca9
into
tari-project:development
|
I cannot get this menu to be displayed when I run the consol wallet: |
Description
Adds commands for exporting a view key and spend key for an existing wallet, and also commands for creating a read-only wallet that only has access to the view key.
Note this is only possible to the great work by @SWvheerden who enabled this functionality in the wallet.
Motivation and Context
This allows you to keep an offline cold wallet that has spend access, and at the same time listen for received funds and act on them. This enables ecommerce and exchange support without the danger of running a hot spending wallet.
How Has This Been Tested?
Tested locally
What process can a PR reviewer use to test or verify this change?
You can follow the steps in the exchange guide to use all of the additions in this PR
Breaking Changes