Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: encode max allowable encrypted bytes into struct #6425

Conversation

SWvheerden
Copy link
Collaborator

Description

remove vec and replace with max_bytes_type

Motivation and Context

Does not allow the allocation of more than max bytes

@SWvheerden SWvheerden requested a review from a team as a code owner July 23, 2024 18:02
sdbondi
sdbondi previously approved these changes Jul 23, 2024
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice utACK

Copy link

github-actions bot commented Jul 23, 2024

Test Results (CI)

    3 files     98 suites   36m 47s ⏱️
1 293 tests 1 292 ✅ 0 💤 1 ❌
2 897 runs  2 896 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit d7807b2.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

Test Results (Integration tests)

 2 files  11 suites   24m 24s ⏱️
35 tests 34 ✅ 0 💤 1 ❌
36 runs  35 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit d7807b2.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jul 23, 2024
@SWvheerden SWvheerden merged commit 65567d5 into tari-project:development Jul 24, 2024
13 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_convert_encrypted_bytes_to_max_type branch July 24, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants