-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file-based input and output to faucet commands #6405
feat: add file-based input and output to faucet commands #6405
Conversation
- Added file-based I/O to faucet commands - Combined faucet script and metadata signature generation steps - Safe-guarded faucet commands: - wallet will exit immediately afterwards; - faucet commands will only be allowed in command mode.
Test Results (CI) 3 files 111 suites 35m 51s ⏱️ For more details on these failures, see this check. Results for commit f9acc2c. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files + 2 11 suites +11 15m 3s ⏱️ + 15m 3s For more details on these failures, see this check. Results for commit f9acc2c. ± Comparison against base commit 7d0281b. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- User feedback for
FaucetEncumberAggregateUtxo
in the wrong scope FaucetCreatePartyDetails
can read the session ID from the supplied file, thus it is not needed as a command line argument.
28c07c0
to
f9acc2c
Compare
* development: (93 commits) chore: fix build and osp (tari-project#6415) chore: refactor key manager names (tari-project#6411) fix: panic in from_base58 fn (tari-project#6414) fix: branch keys (tari-project#6413) chore: remove dependancy on ledger for common types (tari-project#6412) feat: count unique keys (tari-project#6401) feat!: fix key manager use of keys (tari-project#6407) refactor: remove metadata sig and use difference key branch for offset (tari-project#6400) feat: update ledger instructions (tari-project#6406) feat: add file-based input and output to faucet commands (tari-project#6405) chore: new release v1.0.0-pre.16 (tari-project#6404) feat: simplify leader sig generation (tari-project#6399) ci(fix): include macOS universal assets in release (tari-project#6402) fix: script dependance on party order (tari-project#6398) fix: claim n of m faucet (tari-project#6389) feat: add ffi features (tari-project#6390) chore: fix unwraps in memory key manager (tari-project#6396) docs: update hasher documentation (tari-project#6392) chore: fix ci (tari-project#6391) feat(miner): add SHA P2Pool mining related configuration and changes (tari-project#6370) ...
Description
In this PR the following functionality were implemented:
The screen output running the m-of-n spend scenario is shown below.
Step 1 - FaucetGenerateSessionInfo
Step 2 - FaucetCreatePartyDetails
Step 3 - FaucetEncumberAggregateUtxo
Step 4 - FaucetCreateInputOutputSigs
Step 5 - FaucetSpendAggregateUtxo
Motivation and Context
Manual inputs are cumbersome and prone to errors.
How Has This Been Tested?
System-level testing
What process can a PR reviewer use to test or verify this change?
Review code changes
Perform system-level testing
Breaking Changes