Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ffi features #6390

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Add FFI helper functions

Motivation and Context

Add a few helper functions to improve QoL on the FFI

How Has This Been Tested?

unit tests

Copy link

github-actions bot commented Jul 5, 2024

Test Results (CI)

    3 files    120 suites   36m 52s ⏱️
1 295 tests 1 295 ✅ 0 💤 0 ❌
3 877 runs  3 877 ✅ 0 💤 0 ❌

Results for commit 5ff6a9d.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

Test Results (Integration tests)

35 tests  +35   35 ✅ +35   14m 52s ⏱️ + 14m 52s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 5ff6a9d. ± Comparison against base commit 0156fc5.

♻️ This comment has been updated with latest results.

@SWvheerden SWvheerden force-pushed the sw_ffi_improvemtns branch from ce4c411 to 0534e88 Compare July 10, 2024 05:48
brianp
brianp previously approved these changes Jul 10, 2024
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
utAck

base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
@SWvheerden SWvheerden merged commit c0c27a5 into tari-project:development Jul 11, 2024
15 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_ffi_improvemtns branch July 11, 2024 09:37
sdbondi added a commit to sdbondi/tari that referenced this pull request Jul 22, 2024
* development: (93 commits)
  chore: fix build and osp (tari-project#6415)
  chore: refactor key manager names (tari-project#6411)
  fix: panic in from_base58 fn (tari-project#6414)
  fix: branch keys (tari-project#6413)
  chore: remove dependancy on ledger for common types (tari-project#6412)
  feat: count unique keys (tari-project#6401)
  feat!: fix key manager use of keys (tari-project#6407)
  refactor: remove metadata sig and use difference key branch for offset (tari-project#6400)
  feat: update ledger instructions (tari-project#6406)
  feat: add file-based input and output to faucet commands (tari-project#6405)
  chore: new release v1.0.0-pre.16 (tari-project#6404)
  feat: simplify leader sig generation (tari-project#6399)
  ci(fix): include macOS universal assets in release (tari-project#6402)
  fix: script dependance on party order (tari-project#6398)
  fix: claim n of m faucet (tari-project#6389)
  feat: add ffi features (tari-project#6390)
  chore: fix unwraps in memory key manager (tari-project#6396)
  docs: update hasher documentation (tari-project#6392)
  chore: fix ci (tari-project#6391)
  feat(miner): add SHA P2Pool mining related configuration and changes (tari-project#6370)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants