feat: ledger recovery #6383
Merged
feat: ledger recovery #6383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 34m 30s ⏱️ Results for commit 2e6e3fe. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 41m 33s ⏱️ For more details on these failures, see this check. Results for commit 2e6e3fe. ♻️ This comment has been updated with latest results. |
brianp
force-pushed
the
feat-ledger-recovery
branch
from
7544a5c to
880e105
Compare
SWvheerden
reviewed
Jun 28, 2024
After 9 instructions the ledger would not receive instruction 10. Had to be changed to 0x10 to be recognized.
brianp
force-pushed
the
feat-ledger-recovery
branch
from
880e105 to
f038f7f
Compare
SWvheerden
approved these changes
Jul 2, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utilize the view key from the ledger to perform recovery on a wallet, and support one-sided transactions.
Motivation and Context
Allow recovery.
How Has This Been Tested?
Manually
Software -> Software
Ledger -> Software
Ledger -> Ledger
Software recovery
Ledger recovery
What process can a PR reviewer use to test or verify this change?
Please run a manual test between wallets.
Breaking Changes