fix: improve key scanning #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 38m 22s ⏱️ Results for commit 3315ac6. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 1 errors 9 suites 25m 54s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 3315ac6. ♻️ This comment has been updated with latest results. |
base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
Show resolved
Hide resolved
base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
Outdated
Show resolved
Hide resolved
| @@ -265,37 +274,26 @@ where | |||
| /// seen so far. | |||
| async fn update_outputs_script_private_key_and_update_key_manager_index( | |||
| &mut self, | |||
| output: &mut WalletOutput, | |||
| output: &WalletOutput, | |||
There was a problem hiding this comment.
Good catch; the wallet output already has the correct info.
There was a problem hiding this comment.
this function is anyway adding in the wrong info
SWvheerden
force-pushed
the
sw_upate_output_recovery
branch
from
e7579d9 to
1e935d7
Compare
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves utxo scanning with various fixes
Motivation and Context
Scanning for new outputs on the blockchain can be very slow.
How Has This Been Tested?
Manual