feat: remove wallet type from config #6357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 41m 34s ⏱️ For more details on these failures, see this check. Results for commit 31be0f9. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 22m 59s ⏱️ For more details on these failures, see this check. Results for commit 31be0f9. ♻️ This comment has been updated with latest results. |
SWvheerden
previously approved these changes
May 28, 2024
ghpbot-tari-project
removed
the
P-reviews_required
hansieodendaal
force-pushed
the
ho_remove_wallet_type_from_config
branch
from
065fa50 to
31be0f9
Compare
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove wallet type from config.
Motivation and Context
This code is not used anymore, and if someone specifies anything in the config, which should not happen, the wallet panics.
How Has This Been Tested?
System-level testing.
What process can a PR reviewer use to test or verify this change?
Code review.
Breaking Changes