Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload old wallets #6308

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

This allows older wallets that dont have a type stored in the DB to load up as software wallets.

Motivation and Context

If this type is not stored, either the entire DB is corrupted or its an older wallet without a type stored.
If the DB is corrupted it would very likely fail earlier, or if not later. But older correct wallets should not be blocked from booting up

How Has This Been Tested?

Manual

@SWvheerden SWvheerden requested a review from a team as a code owner April 25, 2024 11:07
Copy link

Test Results (CI)

    3 files    120 suites   47m 4s ⏱️
1 277 tests 1 277 ✅ 0 💤 0 ❌
3 823 runs  3 823 ✅ 0 💤 0 ❌

Results for commit 6fc1adc.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Apr 25, 2024
Copy link

Test Results (Integration tests)

33 tests  +33   33 ✅ +33   13m 1s ⏱️ + 13m 1s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 6fc1adc. ± Comparison against base commit cf579f5.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Apr 25, 2024
@SWvheerden SWvheerden merged commit 4cc082d into tari-project:development Apr 26, 2024
15 of 16 checks passed
@SWvheerden SWvheerden deleted the fixwallet branch April 29, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants