feat: multi-network ci #6162
Merged
feat: multi-network ci #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When formally implementing compiler features, the setting of the `TARI_NETWORK`
and (from now) `TARI_TARGET_NETWORK` envar and the related compiler flags matter.
These changes require that when tests run, the correct network flags are set.
For example, `blocks::genesis_block::test::stagenet_genesis_sanity_check` should
only run when `TARI_NETWORK=stagenet`.
The current setup reveals a problem:
There is not a 1:1 mapping between the build _target_ and the actual
network the binary may run on. E.g. the mainnet build can run on either
stagenet or mainnet.
Unfortunately the `TARI_NETWORK` envar was used to set both of these
variables.
Since these are 2 different things, this commit introduced
`TARI_TARGET_NETWORK` which sets the **build target**. In most contexts,
this then decouples the configured network, which is specified by the
`TARI_NETWORK` envar as usual.
The other changes in this commit revolve around updating merkle roots
and the correct faucet sets to make the target/network/faucet
combination consistent.
The CI is configured to run tests for each of `{target} ({network})`
* Testnet (Esme)
* Nextnet (Nextnet)
* Mainnet (Stagenet)
ghpbot-tari-project
added
P-acks_required
Closed
Test Results (CI) 3 files 117 suites 37m 32s ⏱️ Results for commit 1b1ba8b. ♻️ This comment has been updated with latest results. |
leet4tari
reviewed
Feb 21, 2024
SWvheerden
reviewed
Feb 21, 2024
Comment on lines
399
to
400
| // Note: Generate new data for `pub fn get_esmeralda_genesis_block()` and `fn get_esmeralda_genesis_block_raw()` | ||
| // if consensus values change, e.g. new faucet or other |
There was a problem hiding this comment.
Suggested change
| // Note: Generate new data for `pub fn get_esmeralda_genesis_block()` and `fn get_esmeralda_genesis_block_raw()` | |
| // if consensus values change, e.g. new faucet or other |
| @@ -399,11 +393,13 @@ mod test { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn esmeralda_genesis_sanity_check() { | |||
There was a problem hiding this comment.
I dont see a test for esmeralda anymore?
We only have one for nextnet and stagenet
SWvheerden
approved these changes
Feb 26, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When formally implementing compiler features, the setting of the
TARI_NETWORKand (from now)TARI_TARGET_NETWORKenvar and the related compiler flags matter.These changes require that when tests run, the correct network flags are set.
For example,
blocks::genesis_block::test::stagenet_genesis_sanity_checkshould only run whenTARI_NETWORK=stagenet.The current setup reveals a problem:
There is not a 1:1 mapping between the build target and the actual network the binary may run on. E.g. the mainnet build can run on either stagenet or mainnet.
Unfortunately the
TARI_NETWORKenvar was used to set both of these variables.Since these are 2 different things, this commit introduced
TARI_TARGET_NETWORKwhich sets the build target. In most contexts, this then decouples the configured network, which is specified by theTARI_NETWORKenvar as usual.The other changes in this commit revolve around updating merkle roots and the correct faucet sets to make the target/network/faucet combination consistent.
The CI is configured to run tests for each of
{target} ({network})Description
This replaces part of #6131
Breaking Changes