feat!: dont store entire monero coinbase transaction #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 12 suites +12 29m 53s ⏱️ + 29m 53s For more details on these failures, see this check. Results for commit b398beb. ± Comparison against base commit 6723dc7. ♻️ This comment has been updated with latest results. |
SWvheerden
force-pushed
the
sw_coinbase_tx_not_stored
branch
from
d1bf0a4 to
3e9d17a
Compare
SWvheerden
changed the title
hansieodendaal
approved these changes
Dec 1, 2023
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
force-pushed
the
sw_coinbase_tx_not_stored
branch
from
2b2a4f0 to
9dfbf99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
only store the keccak state and not the entire monero coinbase transaction
Motivation and Context
The monero coinbase transaction can be very large as it may contain multiple coinbases. We only store the keccak inner hash state with half of the hashed transaction. We hash the last part to verify its working.
How Has This Been Tested?
unit tests
fixes: #5891