Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add aux chain support for merge mining #5976

Merged
merged 14 commits into from
Nov 29, 2023
Merged

feat!: add aux chain support for merge mining #5976

merged 14 commits into from
Nov 29, 2023

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Nov 22, 2023 •
edited
Loading

Description

This adds aux chain support for merge mining monero

Fixes: #5975

Motivation and Context

This allows tari to be merged mined with multiple other chains, up to 253 other chains.
See: https://github.com/SChernykh/p2pool/blob/merge-mining/docs/MERGE_MINING.MD#proposed-rpc-api

How Has This Been Tested?

@ghpbot-tari-project ghpbot-tari-project added CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 22, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Test Results (Integration tests)

  2 files  12 suites   15m 3s ⏱️
32 tests 30 ✔️ 0 💤 2 ❌
34 runs  32 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 851d165.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Test Results (CI)

1 259 tests   1 259 ✔️  10m 25s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 851d165.

♻️ This comment has been updated with latest results.

@SWvheerden SWvheerden changed the title feat!: Add aux chain support for merge mining feat!: add aux chain support for merge mining Nov 24, 2023
hansieodendaal
hansieodendaal approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Nov 24, 2023
brianp
brianp approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@SWvheerden SWvheerden merged commit 6723dc7 into tari-project:development Nov 29, 2023
13 of 14 checks passed
@SWvheerden SWvheerden deleted the sw_monero_stuff branch December 1, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

@brianp brianp brianp approved these changes

Assignees
No one assigned
Labels
CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

monero merge mining aux chain support
4 participants
@SWvheerden @brianp @hansieodendaal @ghpbot-tari-project