fix!: fix opcode signatures #5966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
AaronFeickert
force-pushed
the
opcode-signatures
branch
from
0d6024f to
ccc0b15
Compare
AaronFeickert
force-pushed
the
opcode-signatures
branch
from
ccc0b15 to
e760b4e
Compare
SWvheerden
approved these changes
Nov 21, 2023
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
pushed a commit
to sdbondi/tari
that referenced
this pull request
Nov 27, 2023
Description --- Fixes opcode signatures to mitigate security issues. Closes tari-project#5817. Motivation and Context --- Handling of signature-related opcodes introduces security issues related to signature forgery as described in tari-project#5817. This PR changes how signature-related message data is handled. Because of the new design, signature arithmetic support is removed. How Has This Been Tested? --- Existing tests pass or have been updated to reflect the new design. What process can a PR reviewer use to test or verify this change? --- Check that the new design matches the intent of the signature-related opcodes. Check that test modifications are correct. BREAKING CHANGE: Changes how some opcodes are processed, which renders some existing scripts and transactions invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes opcode signatures to mitigate security issues.
Closes #5817.
Motivation and Context
Handling of signature-related opcodes introduces security issues related to signature forgery as described in #5817. This PR changes how signature-related message data is handled. Because of the new design, signature arithmetic support is removed.
How Has This Been Tested?
Existing tests pass or have been updated to reflect the new design.
What process can a PR reviewer use to test or verify this change?
Check that the new design matches the intent of the signature-related opcodes. Check that test modifications are correct.
BREAKING CHANGE: Changes how some opcodes are processed, which renders some existing scripts and transactions invalid.