Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: lmdb flag set wrong on database #5916

Merged
merged 4 commits into from
Nov 7, 2023
Merged

fix!: lmdb flag set wrong on database #5916

merged 4 commits into from
Nov 7, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

The database does not use an integer key, but rather a hash.
Small other improvements.

How Has This Been Tested?

Manual

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Test Results (Integration tests)

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8bc052b.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Test Results (CI)

1 253 tests   1 253 ✔️  9m 55s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 8bc052b.

hansieodendaal
hansieodendaal approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Nov 7, 2023
@SWvheerden SWvheerden merged commit 60efd35 into tari-project:development Nov 7, 2023
8 of 11 checks passed
@SWvheerden SWvheerden deleted the sw_small_db_improvements branch November 7, 2023 14:21
@SWvheerden SWvheerden mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project