feat!: completed transaction use bytes for transaction protocol (not hex string) in wallet database #5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the transaction protocol in the wallet database to use bytes instead of a hex string, as the underlying data type is encrypted bytes. This issue was highlighted due to the `to_hex` function in `tari_utilities` not being able to convert large transactions into hex strings (`**String to large**`) during system-level coin-split stress testing.
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 24m 10s ⏱️ + 24m 10s For more details on these failures, see this check. Results for commit 92e37e1. ± Comparison against base commit 1195afb. ♻️ This comment has been updated with latest results. |
hansieodendaal
changed the title
hansieodendaal
changed the title
hansieodendaal
changed the title
hansieodendaal
changed the title
SWvheerden
approved these changes
Nov 6, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the transaction protocol in the wallet database to use bytes instead of a hex string, as the underlying data type is encrypted bytes. This issue was highlighted due to the
to_hexfunction intari_utilitiesnot being able to convert large transactions into hex strings (returned**String to large**) for saving in the wallet database during system-level coin-split stress testing.Motivation and Context
See above.
How Has This Been Tested?
Existing unit tests and cucumber tests passed
Added two new unit tests and a cucumber test (long-running)
System-level test creating a coin-split transaction with 499 outputs passed
What process can a PR reviewer use to test or verify this change?
Code walk-through
Run the new unit tests
Perform a system-level test creating a coin-split transaction with 499 outputs and wait for it to be mined and confirmed,
Breaking Changes
BREAKING CHANGE: All completed transactions in the wallet database will be deleted at startup, while subsequent output validation will re-allocate outputs that were encumbered to be spent as available and invalidate outputs that were encumbered to be received.