Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chatffi): better message metadata parsing #5820

Merged
merged 6 commits into from
Sep 28, 2023
Merged

feat(chatffi): better message metadata parsing #5820

merged 6 commits into from
Sep 28, 2023

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Sep 27, 2023

Description

  • Change metadata adding to byte vectors from strings
  • Adds Message Metadata byte vector reading
  • Changes ptrs to uint for message paging params
  • doc updates

Motivation and Context

Be able to parse metadata mo'betta

How Has This Been Tested?

CI

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@brianp brianp force-pushed the build-ffis-message-metadata-reading branch from 10cc7b7 to ec11c9d Compare September 27, 2023 14:30
@github-actions
Copy link

Test Results (CI)

1 217 tests   1 217 ✔️  9m 55s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit ec11c9d.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 27, 2023
@github-actions
Copy link

Test Results (Integration tests)

29 tests   29 ✔️  13m 5s ⏱️
11 suites    0 💤
  2 files      0 ❌

Results for commit ec11c9d.

@brianp brianp requested a review from SWvheerden September 27, 2023 15:16
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 28, 2023
@SWvheerden SWvheerden merged commit 9a43eab into tari-project:development Sep 28, 2023
13 checks passed
@brianp brianp deleted the build-ffis-message-metadata-reading branch September 28, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianp @SWvheerden @ghpbot-tari-project