Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grpc request overflows #5812

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix: grpc request overflows #5812

merged 2 commits into from
Sep 29, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

Adds checked requests to potential overflows in grpc requests

@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Sep 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

Test Results (CI)

1 217 tests   1 217 ✔️  12m 11s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 2711b68.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 26, 2023
@github-actions
Copy link

Test Results (Integration tests)

  2 files  +  2  11 suites  +11   22m 34s ⏱️ + 22m 34s
29 tests +29  28 ✔️ +28  0 💤 ±0  1 ❌ +1 
30 runs  +30  29 ✔️ +29  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 09a6fac. ± Comparison against base commit 6c8e2d3.

brianp
brianp approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

TIL: Saturating addition is addition within bounds. Neat.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 29, 2023
@SWvheerden SWvheerden merged commit 36d72e8 into tari-project:development Sep 29, 2023
11 of 12 checks passed
@SWvheerden SWvheerden deleted the sw_fix_overflow branch October 25, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianp brianp brianp approved these changes

Assignees
No one assigned
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @brianp @ghpbot-tari-project