Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get rid of possible 'expect' #5794

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: get rid of possible 'expect' #5794

merged 1 commit into from
Sep 22, 2023

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Sep 21, 2023 •
edited
Loading

Description

Get rid of possible 'expect'

Motivation and Context

Better pattern to use

How Has This Been Tested?

Unit tests

What process can a PR reviewer use to test or verify this change?

Code walk through

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

sdbondi
sdbondi approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice that prost added infallible encoding

@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Sep 21, 2023
@github-actions
Copy link

Test Results (CI)

1 216 tests   1 216 ✔️  10m 9s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 7b07de6.

@github-actions
Copy link

Test Results (Integration tests)

29 tests   29 ✔️  13m 6s ⏱️
11 suites    0 💤
  2 files      0 ❌

Results for commit 7b07de6.

@SWvheerden SWvheerden merged commit 467a8d4 into tari-project:development Sep 22, 2023
@hansieodendaal hansieodendaal deleted the ho_remove_expect branch September 22, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronFeickert AaronFeickert AaronFeickert approved these changes

@SWvheerden SWvheerden SWvheerden approved these changes

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hansieodendaal @sdbondi @SWvheerden @AaronFeickert @ghpbot-tari-project