Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console Wallet]make wallet exit on startup of wrong db existing version #5264

Open
SWvheerden opened this issue Mar 22, 2023 · 3 comments
Open

[Console Wallet]make wallet exit on startup of wrong db existing version #5264

SWvheerden opened this issue Mar 22, 2023 · 3 comments
Labels
A-wallet Area - related to the wallet C-enhancement Category - New feature or request E-good_first_issue Experience Level - Good for newcomers

Comments

@SWvheerden
Copy link
Collaborator

SWvheerden commented Mar 22, 2023 •
edited
Loading

Pending #5252
The wallet can read the network version that last opened it up.
If the network does not match, close the wallet with an appropriate error message.
@SWvheerden SWvheerden converted this from a draft issue Mar 22, 2023
@SWvheerden SWvheerden changed the title make wallet exit on startup of wrong existing version [ Wallet]make wallet exit on startup of wrong existing version Mar 22, 2023
@SWvheerden SWvheerden added C-enhancement Category - New feature or request A-wallet Area - related to the wallet E-good_first_issue Experience Level - Good for newcomers labels Mar 22, 2023
@SWvheerden SWvheerden changed the title [ Wallet]make wallet exit on startup of wrong existing version [ Wallet]make wallet exit on startup of wrong db existing version Mar 28, 2023
@SWvheerden SWvheerden moved this to Must Do in Tari Esme Testnet Mar 28, 2023
@brianp
Copy link
Contributor

brianp commented Jun 2, 2023

#5252 was fixed with #5263. Is this issue still relevant?

@SWvheerden
Copy link
Collaborator Author

SWvheerden commented Jan 9, 2024 •
edited
Loading

yes, this is for console wallet application it self, which does not check or use this yet

@SWvheerden SWvheerden changed the title [ Wallet]make wallet exit on startup of wrong db existing version [Console Wallet]make wallet exit on startup of wrong db existing version Jan 9, 2024
@SWvheerden
Copy link
Collaborator Author

We should probably check the type as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-wallet Area - related to the wallet C-enhancement Category - New feature or request E-good_first_issue Experience Level - Good for newcomers
Projects
Tari Esme Testnet
Status: Must Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianp @SWvheerden