-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stagenet network #5173
feat: stagenet network #5173
Conversation
724e441
to
6f411b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far
let accumulated_data = BlockHeaderAccumulatedData { | ||
hash: block.hash(), | ||
total_kernel_offset: block.header.total_kernel_offset.clone(), | ||
achieved_difficulty: 1.into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the actual difficulty of the block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the difficulty emse has so I left it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check if this is the stagenet difficulty as well.
a401038
to
a8852e3
Compare
Adds StageNet, with consnsus and genesis block in preparation for the release of the StageNet network.
f39b0bd
to
af54946
Compare
}); | ||
algos.insert(PowAlgorithm::Monero, PowAlgorithmConstants { | ||
max_target_time: 1200, | ||
min_difficulty: 70_000_000.into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is too high and will prevent mining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like this was the placeholder value from mainnet
and not the value from esme. Updated to match the esme value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge once the monero difficulty is confirmed
Adds additional configuration for StageNet as the deafult network.
af54946
to
c19b1f6
Compare
Description
This PR introduces the genesis block, and consensus for the upcoming StageNet network.
Apart from this PR I've generated seed node identities, which will be added to the seeds after this is merged, and the seeds are brought up.
Motivation and Context
Get into release cycle habits and hygiene.
How Has This Been Tested?
CI (but I'm expecting some test to fail on first pass due to the default network change).