Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stagenet network #5173

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Feb 9, 2023

Description

This PR introduces the genesis block, and consensus for the upcoming StageNet network.

Apart from this PR I've generated seed node identities, which will be added to the seeds after this is merged, and the seeds are brought up.

Motivation and Context

Get into release cycle habits and hygiene.

How Has This Been Tested?

CI (but I'm expecting some test to fail on first pass due to the default network change).

@brianp brianp marked this pull request as ready for review February 9, 2023 02:20
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

let accumulated_data = BlockHeaderAccumulatedData {
hash: block.hash(),
total_kernel_offset: block.header.total_kernel_offset.clone(),
achieved_difficulty: 1.into(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the actual difficulty of the block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the difficulty emse has so I left it as is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check if this is the stagenet difficulty as well.

base_layer/core/src/blocks/genesis_block.rs Outdated Show resolved Hide resolved
base_layer/core/src/consensus/consensus_constants.rs Outdated Show resolved Hide resolved
@brianp brianp force-pushed the feature-stagenet branch 2 times, most recently from a401038 to a8852e3 Compare February 13, 2023 15:56
Adds StageNet, with consnsus and genesis block in preparation for the
release of the StageNet network.
});
algos.insert(PowAlgorithm::Monero, PowAlgorithmConstants {
max_target_time: 1200,
min_difficulty: 70_000_000.into(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is too high and will prevent mining

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like this was the placeholder value from mainnet and not the value from esme. Updated to match the esme value.

Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once the monero difficulty is confirmed

Adds additional configuration for StageNet as the deafult network.
@stringhandler stringhandler merged commit d2717a1 into tari-project:development Feb 14, 2023
@brianp brianp deleted the feature-stagenet branch February 14, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants