Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base node] Fix pub fn batch_verify_range_proofs(..) to not use powers of two, but batch all proofs #5048

Closed
hansieodendaal opened this issue Dec 13, 2022 · 2 comments · Fixed by #5049

Comments

@hansieodendaal
Copy link
Contributor

No description provided.

@hansieodendaal hansieodendaal converted this from a draft issue Dec 13, 2022
@AaronFeickert
Copy link
Collaborator

Just for clarity, range proofs require a power of two for the aggregation factor; that is, the number of (possibly padded) commitments whose range is asserted in a single proof must be a power of two. The number of proofs that may be verified in a batch is arbitrary, and limited in practice only by any performance concerns relating to multiscalar multiplication and the like.

For batches so large that performance becomes a concern, we can simply split into smaller batches and evaluate them separately.

@AaronFeickert
Copy link
Collaborator

Here's the relevant code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants