Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: functional wallet encryption (issue #5007) #5043

Merged
merged 14 commits into from
Jan 10, 2023
Merged

fix: functional wallet encryption (issue #5007) #5043

merged 14 commits into from
Jan 10, 2023

Conversation

jorgeantonio21
Copy link
Contributor

Description

Wallet encryption and decryption is now done via pure methods, instead of mutating in place the required fields, see #5007.

Motivation and Context

Address issue #5007.

How Has This Been Tested?

Existing unit tests.

stringhandler
stringhandler reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better, but I'd prefer the encryption and decryption to occur in the conversion to and from the .....Sql types, so that a ....Sql type is always encrypted and the non-sql type is always decrypted, but zeroized

base_layer/wallet/src/key_manager_service/storage/sqlite_db/mod.rs Show resolved Hide resolved
base_layer/wallet/src/key_manager_service/storage/sqlite_db/key_manager_state.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/key_manager_service/storage/sqlite_db/mod.rs Outdated Show resolved Hide resolved
@CjS77 CjS77 added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Dec 12, 2022
@jorgeantonio21 jorgeantonio21 force-pushed the ja-pure-functional-encryption branch from 0e700cf to 142f835 Compare December 13, 2022 09:27
SWvheerden
SWvheerden requested changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going backwards with regards to zeroizing the data after use.

I made a comment how to fix this in the PR

base_layer/wallet/src/key_manager_service/storage/sqlite_db/mod.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/key_manager_service/storage/sqlite_db/key_manager_state.rs Show resolved Hide resolved
base_layer/wallet/src/key_manager_service/storage/sqlite_db/mod.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs Show resolved Hide resolved
base_layer/wallet/src/output_manager_service/storage/sqlite_db/output_sql.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/storage/sqlite_db/wallet.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/util/encryption.rs Show resolved Hide resolved
base_layer/wallet/src/transaction_service/storage/sqlite_db.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/transaction_service/storage/sqlite_db.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/transaction_service/storage/sqlite_db.rs Outdated Show resolved Hide resolved
SWvheerden
SWvheerden previously approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

base_layer/wallet/tests/transaction_service_tests/service.rs Outdated Show resolved Hide resolved
stringhandler
stringhandler approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@stringhandler stringhandler merged commit 7b2311e into tari-project:development Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

@SWvheerden SWvheerden SWvheerden left review comments

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorgeantonio21 @SWvheerden @stringhandler @CjS77