fix(wallet): invalid metadata sig when creating code template utxo #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
added a commit
to tari-project/tari-dan
that referenced
this pull request
Nov 29, 2022
Description --- Uses `development` branch instead of `feature-dan` Motivation and Context --- `feature-dan` was merged into `development` How Has This Been Tested? --- Manually, with fix from tari-project/tari#4975
stringhandler
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
create_send_to_self_with_outputgenerates a transaction with an invalid metadata signature. This function is used bycreate_template_registrationin wallet GRPC.In order to send a send-to-self transaction, the UnblindedOutputBuilder needs to create a complete signature for the new output.
The UnblindedOutputBuilder is only currently used in create_pay_to_self_containing_outputs calls.
How Has This Been Tested?
Manually, able to submit a valid template reg utxo