fix: node gets banned on reorg #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to simplify the if/else nested branches. The result is three much simpler branches but the overall formatting is much more daunting. So i could take it or leave it.
brianp
force-pushed
the
fix-4799-node-gets-banned-on-reorg
branch
from
58e3cde to
3c55b18
Compare
|
Got the failing test all worked out but now it's segfault'ing during syncs. I've already got an idea why that might be happening. New fix is incoming. |
|
segfault fix pushed. I had gotten a little too overzealous with the code removal. Removing the grpc response formats for HistoricalBlocks results in segfault when syncing. I've re-added the hastily removed code and the segfault no longer occurs. Good for review now. |
stringhandler
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
FetchBlocksByHashhandler. It was only called from a single place and although designed to handle multiple blocks it was only ever sending a single hash at once making the multi-block functionality useless.Instead, opt to use the existing
GetBlockByHashhandler and expand that handler to accept a neworphansflag. Passing this flag means we'll accept found blocks from the orphan pool,Motivation and Context
Previously if a node had re-orged after a sync had started it may result in not providing the complete block for a block it claimed it had. This results in a brief ban.
Make it also return blocks from the orphan pool and let the peer figure out what to do with it.
How Has This Been Tested?
Tests, and running nodes.
Fixes: #4799