fix: console wallet timestamp display #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added `Mined At (Local)` field to transaction details
stringhandler
approved these changes
Nov 28, 2022
CjS77
added a commit
that referenced
this pull request
Apr 5, 2023
PR #4942 added a row to the tx detail view, but did not increase the size of the box. As a result, the maturity is cut off. This PR makes the detail box one row wider, and adjusts the minimum size of the tx box to be 8 (this is the absolute minimum -- accounting for headers and one each of pending and completed txs). Fixes #5289
ghpbot-tari-project
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR #4942 added a row to the tx detail view, but did not increase the size of the box. As a result, the maturity is cut off. This PR makes the detail box one row wider, and adjusts the minimum size of the tx box to be 8 (this is the absolute minimum -- accounting for headers and one each of pending and completed txs). Fixes #5289 ``` Tari Console Wallet────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Transactions │ Send │ Receive │ Contacts │ Network │ Events │ Log │ Notifications │ └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ ┌Balance────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │Available: 0 µT (Time Locked: 0 µT) Pending Incoming: 0 µT Pending Outgoing: 0 µT │ └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ Up↑/Down↓ select Tx (C) cancel selected pending Txs (A) show/hide mining (R) rebroadcast Txs (Esc) exit list ┌Completed (T)ransactions (0) ──────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Source/Destination Address Amount/Token Mined At (Local) Status │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ ┌Transaction Details────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │TxID: │ │Source Address: │ │Destination address: │ │Direction: │ │Amount: │ │Fee: │ │Status: │ │Message: │ │Mined At (Local): │ │Imported At (Local): │ │Excess: │ │Confirmations: │ │Mined Height: │ │Maturity: │ └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ Base Node Status - Chain Tip: #12365 Synced. Latency 562 ms Connected Base Node ID: 99999903f5951fa1ca9505c3c2 ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Network: stagenet Version: 0.49.0-pre.5 LeftArrow: Previous Tab Tab/RightArrow: Next Tab F10/Ctrl-Q: Quit ```
SWvheerden
added a commit
that referenced
this pull request
Apr 5, 2023
## [0.49.0-pre.6](v0.49.0-pre.5...v0.49.0-pre.6) (2023-04-05) ### ⚠ BREAKING CHANGES * move key manager service to key_manager (5284) * add igor faucet (5281) * reset dates for networks (5283) ### Features * add igor faucet ([5281](#5281)) ([bfc92fd](bfc92fd)) * added auxiliary callback to push base node state changes [5109](#5109) ([#5257](#5257)) ([b7f7d31](b7f7d31)) * move key manager service to key_manager ([5284](#5284)) ([d50ed02](d50ed02)) * reset dates for networks ([5283](#5283)) ([d6342a4](d6342a4)) ### Bug Fixes * resize transaction tab windows ([5290](#5290)) ([bd95a85](bd95a85)), closes [#4942](#4942) [#5289](#5289) [#12365](https://github.com/tari-project/tari/issues/12365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed timestamp columns from
Local Date/TimetoMined At (Local)andImported At (Local), also addedmined_timestampto transaction details section.DRAFT NOTE: still need to resolve the issue with
timestampbeing ahead ofmined_timestampMotivation and Context
#4923
Imported transactions in the wallet should show the block time, not the time they are imported
How Has This Been Tested?