fix(core/metrics): set target difficulty as single value #4902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
base_node::blockchain::target_difficulty_shaandbase_node::blockchain::target_difficulty_moneroare now single values at any point in time rather than qualified by block height.Motivation and Context
I was not able to find a way (many months ago) to produce a performant non-timeseries graph that used height as the x-axis. The way I found tended to produce a lot of data on the endpoint side and crash grafana. We used a timeseries graph with an aggregation, producing an average difficulty over a time period. This PR allows for the precise difficulty w.r.t real time which I feel is better.
How Has This Been Tested?
Not tested, code compiles and this is how a lot of metric values work.